Changes to make compatible with noPatch version of ShadyDOM [3.x]
#5452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 26, 2018 15:13
* Polymer.dom uses ShadyDOM.wrap * LegacyElementMixin _attachDOM uses ShadyDOM.wrap
This reverts commit 0f022df.
Sync'd with Polymer 1 wrap locations
Re-use code in Polymer.dom when in noPatch mode.
ShadyDOM type not working. Disabling to see if tests otherwise pass.
Everything should work even if a version of ShadyDOM that does not support `noPatch` is loaded. Also, re-enable type generation and privatize problematic type.
This ensures attributes bindings to class, name, and slot behave correctly when `ShadyDOM.noPatch` is set.
When `ShadyDOM.noPatch` is set, this ensures that firing an event triggers distribution.
Uses new `ShadyDOM.flushInitial(shadowRoot)` API. This better matches the behavior of Polymer 1.
This separates the behavior from `legacyOptimizations`. Performs synchronous initial rendering under ShadyDOM when this flag is set.
kevinpschaaf
requested changes
Feb 6, 2019
Backport closure compiler fixes from internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.